From 9c211f5139917fcaf7ee9e25017c5638f56ac820 Mon Sep 17 00:00:00 2001 From: randomuser Date: Tue, 20 Sep 2022 16:49:14 -0500 Subject: [PATCH] remove buffer overflow vulnerability --- bspc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bspc.c b/bspc.c index c7826cb..061619b 100644 --- a/bspc.c +++ b/bspc.c @@ -319,8 +319,7 @@ int bspwm_update(struct module *module) { break; } if(isdigit(module->buffer[i]) && *current == module->buffer[i]) { - /* XXX: susceptible to buffer overflow */ - if(i == MODULE_BUFFER_LEN) module->buffer[i + 1] = '<'; + if(i <= MODULE_BUFFER_LEN - 2) module->buffer[i + 1] = '<'; *current = '\0'; } if(module->buffer[i] == '\n')